]> git.apps.os.sepia.ceph.com Git - ceph-build.git/commit
*/build_deb: pass env vars with quotes 942/head
authorKefu Chai <tchaikov@gmail.com>
Thu, 4 Jan 2018 07:01:47 +0000 (15:01 +0800)
committerKefu Chai <kchai@redhat.com>
Fri, 5 Jan 2018 14:32:24 +0000 (22:32 +0800)
commit7203d4a34e2a176043538d28de01b01997950d18
treeca6dc13f1f4090a8225413ef62a01f1f6d935941
parentda787ef57ef671e8e63cbcf0671c33e0412b7ed9
*/build_deb: pass env vars with quotes

should double quote env var in command substitution, otherwise shell will
perform field splitting with the substitution, and only the first element in
it will be consumed. that's why CEPH_EXTRA_CMAKE_ARGS will always be
`-DALLOCATOR=libc` when it reaches debian/rules, even if
'CEPH_EXTRA_CMAKE_ARGS' is "-DALLOCATOR=libc -DWITH_STATIC_LIBSTDCXX=ON",
and it is passed to pbuilder like:

sudo CEPH_EXTRA_CMAKE_ARGS=$CEPH_EXTRA_CMAKE_ARGS pbuilder ...

Fixes: http://tracker.ceph.com/issues/22465
Signed-off-by: Kefu Chai <kchai@redhat.com>
ceph-build/build/build_deb
ceph-dev-build/build/build_deb
ceph-dev-new-build/build/build_deb