mon/OSDMonitor: make per-OSD no{out,down,in,out} flags prior to CRUSH nodes

This way we 'll be more compatible with older versions, and can effectively
reduce the map size for large clusters.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

diff --git a/src/mon/OSDMonitor.cc b/src/mon/OSDMonitor.cc
index ecbb5cd27113bb62b596d2fdf403613d474eadde..e913c64a00f9115556098589065f1911636846d8 100644 (file)
--- a/src/mon/OSDMonitor.cc
+++ b/src/mon/OSDMonitor.cc
@@ -10582,11 +10582,11 @@ bool OSDMonitor::prepare_command_impl(MonOpRequestRef op,
         osdmap.get_all_osds(osds);
         stop = true;
       } else {
-       if (osdmap.crush->name_exists(idvec[j])) {
+        if (long osd = parse_osd_id(idvec[j].c_str(), &ss); osd >= 0) {
+          osds.insert(osd);
+       } else if (osdmap.crush->name_exists(idvec[j])) {
+          std::stringstream().swap(ss);
          crush_nodes.insert(osdmap.crush->get_item_id(idvec[j]));
-       } else if (long osd = parse_osd_id(idvec[j].c_str(), &ss);
-                  osd >= 0) {
-         osds.insert(osd);
        } else {
          // ss has reason for failure
          ss << ", unable to parse osd id or crush node:\"" << idvec[j]
@@ -10796,11 +10796,11 @@ bool OSDMonitor::prepare_command_impl(MonOpRequestRef op,
 
         stop = true;
       } else {
-       if (osdmap.crush->name_exists(idvec[j])) {
-         crush_nodes.insert(osdmap.crush->get_item_id(idvec[j]));
-       } else if (long osd = parse_osd_id(idvec[j].c_str(), &ss);
-                  osd >= 0) {
+       if (long osd = parse_osd_id(idvec[j].c_str(), &ss); osd >= 0) {
          osds.push_back(osd);
+        } else if (osdmap.crush->name_exists(idvec[j])) {
+          std::stringstream().swap(ss);
+          crush_nodes.insert(osdmap.crush->get_item_id(idvec[j]));
        } else {
          // ss has reason for failure
          ss << ", unable to parse osd id or crush node:\"" << idvec[j]