]> git.apps.os.sepia.ceph.com Git - teuthology.git/commitdiff
Remove buggy error checking in lock_machines() 582/head
authorZack Cerza <zack@redhat.com>
Fri, 24 Jul 2015 18:43:08 +0000 (12:43 -0600)
committerZack Cerza <zack@redhat.com>
Fri, 24 Jul 2015 18:43:08 +0000 (12:43 -0600)
http://tracker.ceph.com/issues/12462

If lock_many() fails to create any VMs, it returns an empty dict, which
was causing an exception to be raised. The existing error reporting in
lock_many() should be adequate here.

Signed-off-by: Zack Cerza <zack@redhat.com>
teuthology/task/internal.py

index a35552b457c5cfc9d3db7591c73c62a048f8d558..44fe265b97d2fbb9a3ef4ca2a2ee3b50e935c013 100644 (file)
@@ -117,8 +117,6 @@ def lock_machines(ctx, config):
 
         newly_locked = lock.lock_many(ctx, how_many, machine_type, ctx.owner,
                                       ctx.archive, os_type, os_version, arch)
-        if not newly_locked and not isinstance(newly_locked, list):
-            raise RuntimeError('Invalid parameters specified')
         all_locked.update(newly_locked)
         if len(all_locked) == how_many:
             vmlist = []