]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
pybind/mgr/pg_autoscaler: fix warn when not too few pgs
authorKamoltat <ksirivad@redhat.com>
Mon, 5 Jun 2023 17:17:32 +0000 (17:17 +0000)
committerKamoltat <ksirivad@redhat.com>
Tue, 26 Sep 2023 14:33:34 +0000 (14:33 +0000)
Problem:

when `pg_num_final` is equal to `pg_num_target`
we get too many PGs warnings in ceph health while
`warn` mode in the autoscaler.

Solution:

Get rid of `else` condition and add an
`elif p['pg_num_final'] < p['pg_num_target']`
instead

Fixes: https://tracker.ceph.com/issues/61570
Signed-off-by: Kamoltat <ksirivad@redhat.com>
(cherry picked from commit bfef56701f576d1a62017d313839a0c36949ac00)

src/pybind/mgr/pg_autoscaler/module.py

index 13e1cff9e8838655cf151df676847a2fc9153d1c..ca6ca76c4b7583f44418d06701861e64ada0ebe5 100644 (file)
@@ -726,7 +726,7 @@ class PgAutoscaler(MgrModule):
                     p['pg_num_final'])
                 if p['pg_num_final'] > p['pg_num_target']:
                     too_few.append(msg)
-                else:
+                elif p['pg_num_final'] < p['pg_num_target']:
                     too_many.append(msg)
             if not p['would_adjust']:
                 continue