Boolean functions should end in ?

diff --git a/libraries/default.rb b/libraries/default.rb
index 69f031551271a697448bc98ba9ca349b9bdb69e7..47d010103fd8e879185e8943f50aa0502987b64c 100644 (file)
--- a/libraries/default.rb
+++ b/libraries/default.rb
@@ -34,13 +34,13 @@ def find_node_ip_in_network(network, nodeish = nil)
   nodeish['network']['interfaces'].each do |iface, addrs|
     addresses = addrs['addresses'] || []
     addresses.each do |ip, params|
-      return ip_address_to_ceph_address(ip, params) if ip_address_in_network(ip, params, net)
+      return ip_address_to_ceph_address(ip, params) if ip_address_in_network?(ip, params, net)
     end
   end
   nil
 end
 
-def ip_address_in_network(ip, params, net)
+def ip_address_in_network?(ip, params, net)
   ['inet', 'inet6'].include?(params['family']) && net.include?(ip)
 end