]> git-server-git.apps.pok.os.sepia.ceph.com Git - teuthology.git/commitdiff
fix couple flake8 issues
authorVasu Kulkarni <vasu@redhat.com>
Fri, 15 Feb 2019 17:08:35 +0000 (09:08 -0800)
committerVasu Kulkarni <vasu@redhat.com>
Fri, 15 Feb 2019 17:13:49 +0000 (09:13 -0800)
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>
teuthology/coverage_report_standalone.py
teuthology/misc.py

index c04459cd7abd8fd802214284809c7d55900734a6..bfeedf1f7f2d7d1cbf6d2385e855b238acab6230 100644 (file)
@@ -29,8 +29,7 @@ def gen_results(data_src, outdir):
 
     cmd = "{cmd} -o {merg_info}".format(cmd=cmd, merg_info=merged_info)
     print cmd
-    proc = subprocess.Popen(shlex.split(cmd), stdout=subprocess.PIPE)
-    proc_stdout = proc.communicate()[0]
+    subprocess.Popen(shlex.split(cmd), stdout=subprocess.PIPE)
     assert(os.path.exists(merged_info))
 
     ''' remove unncessary includes '''
@@ -38,8 +37,7 @@ def gen_results(data_src, outdir):
                                                format( merge_file=merged_info,
                                                        fltr=merged_filterd)
     print cmd
-    proc = subprocess.Popen(shlex.split(cmd), stdout=subprocess.PIPE)
-    proc_stdout = proc.communicate()[0]
+    subprocess.Popen(shlex.split(cmd), stdout=subprocess.PIPE)
     assert(os.path.exists(merged_filterd))
 
     '''genhtml report and put it in outdir'''
@@ -47,8 +45,7 @@ def gen_results(data_src, outdir):
                                        merged_filterd=merged_filterd,
                                        outdir=outdir)
     print cmd
-    proc = subprocess.Popen(shlex.split(cmd), stdout=subprocess.PIPE)
-    proc_stdout = proc.communicate()[0]
+    subprocess.Popen(shlex.split(cmd), stdout=subprocess.PIPE)
     assert(os.path.exists(outdir+ "/index.html"))
 
 
@@ -150,7 +147,6 @@ def do_coverage(args):
        /run_name_dir/job/ceph/remote/remote_name/coverage/<builddir>.
        <builddir> follows convention /builddir/build/BUILD/<ceph-version>/
        '''
-       rundir = args.rundir
        if args.src:
            srcdir = args.src
        else:
index f46e387215b3934cea43ea32b47bc18a4ec669a6..ecbacde93418c870aeb45c267b26538fde079c51 100644 (file)
@@ -20,7 +20,6 @@ import yaml
 import json
 import re
 import pprint
-import parallel
 
 
 from netaddr.strategy.ipv4 import valid_str as _is_ipv4