common/rc: cleanup old .kmemleak files

I've spent a non-negligible amount of time looking into a kmemleak that
didn't exist in the code I was testing because there was an old .kmemleak
file in the results directory.  I don't think this is an intended behaviour,
so I'm proposing to remove these files everytime we capture the result of a
new scan.

Signed-off-by: Luís Henriques <lhenriques@suse.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Zorro Lang <zlang@kernel.org>

diff --git a/common/rc b/common/rc
index 741579af82d25a14a95dd017f1c814342bf6d0f0..5c4429ed04250268e45a5c371231b7364d9aea91 100644 (file)
--- a/common/rc
+++ b/common/rc
@@ -4433,6 +4433,10 @@ _capture_kmemleak()
        local kern_knob="$DEBUGFS_MNT/kmemleak"
        local leak_file="$1"
 
+       # Some callers pass in /dev/null when they want to clear the
+       # kernel's leak report file and do not care what was in that.
+       [ -f "$leak_file" ] && rm -f "$leak_file"
+
        # Tell the kernel to scan for memory leaks.  Apparently the write
        # returns before the scan is complete, so do it twice in the hopes
        # that twice is enough to capture all the leaks.