ansible: Don't modify plays

We were applying hosts=all to each play when using a generated playbook.
I can't remember why I thought that was a good idea, and it's tripping
up CephAnsible.

Signed-off-by: Zack Cerza <zack@redhat.com>

diff --git a/teuthology/task/ansible.py b/teuthology/task/ansible.py
index 708cc3bf30fc32cb533c5627060ecd3f6e6cba47..f290682399d81b1913ae2754ad34cdee1527f3df 100644 (file)
--- a/teuthology/task/ansible.py
+++ b/teuthology/task/ansible.py
@@ -217,10 +217,6 @@ class Ansible(Task):
         Generate a playbook file to use. This should not be called if we're
         using an existing file.
         """
-        for play in self.playbook:
-            # Ensure each play is applied to all hosts mentioned in the --limit
-            # flag we specify later
-            play['hosts'] = 'all'
         pb_buffer = StringIO()
         pb_buffer.write('---\n')
         yaml.safe_dump(self.playbook, pb_buffer)

diff --git a/teuthology/test/task/test_ansible.py b/teuthology/test/task/test_ansible.py
index 3c325b5c592a2b398c9ee33b5b73a48f6d1e2acd..09131c32e123ee77bc21abc5e27497a0b19d99db 100644 (file)
--- a/teuthology/test/task/test_ansible.py
+++ b/teuthology/test/task/test_ansible.py
@@ -238,8 +238,6 @@ class TestAnsibleTask(TestTask):
         assert task.playbook_file == playbook_file_obj
         playbook_file_obj.seek(0)
         playbook_result = yaml.safe_load(playbook_file_obj)
-        for play in playbook:
-            play['hosts'] = 'all'
         assert playbook_result == playbook
 
     def test_execute_playbook(self):