mgr/dashboard: cypress tests do not fail on failures

- the on 'fail' requires errors to be thrown explicitly
- this is causing all tests to pass as of now irrescpective fo failures

Fixes https://tracker.ceph.com/issues/72292

Signed-off-by: Afreen Misbah <afreen@ibm.com>

diff --git a/src/pybind/mgr/dashboard/frontend/cypress/e2e/orchestrator/workflow/09-services.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/cypress/e2e/orchestrator/workflow/09-services.e2e-spec.ts
index 03d4a8785187ed86ec3d7347958aacf560a4afeb..88b8ab4c9ea5a101312786507dad40e414898a90 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/cypress/e2e/orchestrator/workflow/09-services.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/cypress/e2e/orchestrator/workflow/09-services.e2e-spec.ts
@@ -98,7 +98,6 @@ describe('Services page', () => {
     cy.get('cd-service-details').within(() => {
       services.checkServiceStatus('snmp-gateway');
     });
-    services.clickServiceTab('snmp-gateway', 'Daemons');
 
     services.deleteService('snmp-gateway');
   });
@@ -112,7 +111,6 @@ describe('Services page', () => {
     cy.get('cd-service-details').within(() => {
       services.checkServiceStatus('snmp-gateway');
     });
-    services.clickServiceTab('snmp-gateway', 'Daemons');
 
     services.deleteService('snmp-gateway');
   });

diff --git a/src/pybind/mgr/dashboard/frontend/cypress/support/e2e.ts b/src/pybind/mgr/dashboard/frontend/cypress/support/e2e.ts
index 8b55b576589d07ba9d8bb08af667def2ab9973dd..bfcdd775dcc48e92dc6472ce1ab19d1259ed4746 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/cypress/support/e2e.ts
+++ b/src/pybind/mgr/dashboard/frontend/cypress/support/e2e.ts
@@ -22,5 +22,5 @@ Cypress.on('fail', (err: Error) => {
   if (err.message.includes('xhr') && err.message.includes('canceled')) {
     return false; // Ignore canceled XHR requests
   }
-  return true;
+  throw err;
 });