]> git.apps.os.sepia.ceph.com Git - xfsprogs-dev.git/commitdiff
xfs: remove the unusued tmp_logflags variable in xfs_bmapi_allocate
authorChristoph Hellwig <hch@lst.de>
Mon, 29 Jul 2024 23:22:54 +0000 (16:22 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Tue, 30 Jul 2024 00:01:04 +0000 (17:01 -0700)
Source kernel commit: b11ed354c9f725ece2b9440dd6343b42cd5d031c

tmp_logflags is initialized to 0 and then ORed into bma->logflags, which
isn't actually doing anything.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
libxfs/xfs_bmap.c

index 84760c889829ba7857c1793358c35abd65f27422..f236e40d1c7db3125ebb384cbcbc9e5ffc7e6919 100644 (file)
@@ -4176,7 +4176,6 @@ xfs_bmapi_allocate(
        struct xfs_mount        *mp = bma->ip->i_mount;
        int                     whichfork = xfs_bmapi_whichfork(bma->flags);
        struct xfs_ifork        *ifp = xfs_ifork_ptr(bma->ip, whichfork);
-       int                     tmp_logflags = 0;
        int                     error;
 
        ASSERT(bma->length > 0);
@@ -4247,8 +4246,6 @@ xfs_bmapi_allocate(
                error = xfs_bmap_add_extent_hole_real(bma->tp, bma->ip,
                                whichfork, &bma->icur, &bma->cur, &bma->got,
                                &bma->logflags, bma->flags);
-
-       bma->logflags |= tmp_logflags;
        if (error)
                return error;