]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/osd/pg_shard_manager: remove the unnecessary "std::move" call 58029/head
authorXuehan Xu <xuxuehan@qianxin.com>
Fri, 24 May 2024 09:35:47 +0000 (17:35 +0800)
committerMatan Breizman <mbreizma@redhat.com>
Thu, 13 Jun 2024 12:42:08 +0000 (15:42 +0300)
Fixing the following compilation issue:
/home/xuxuehan/src/ceph/src/crimson/osd/pg_shard_manager.h:236:7: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
  236 |       );
      |       ^
/home/xuxuehan/src/ceph/src/crimson/osd/pg_shard_manager.h:236:7: note: remove ‘std::move’ call

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
(cherry picked from commit 3d77b5c7e2ed95d424cdc9b97f9b41cea1a2648a)

src/crimson/osd/pg_shard_manager.h

index 965d6ab0e16ba3d9ac8e2411b41806b1fd98543e..b9879c8c9ddde89fec1093720e25c97d2acfe894 100644 (file)
@@ -232,7 +232,7 @@ public:
       return target_shard_services.get_or_create_pg(
         std::move(trigger),
         opref.get_pgid(),
-        std::move(opref.get_create_info())
+        opref.get_create_info()
       );
     }).safe_then([&logger, &target_shard_services, &opref](Ref<PG> pgref) {
       logger.debug("{}: have_pg", opref);