]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commitdiff
hwmon: (it87) Check the it87_lock() return value
authorBart Van Assche <bvanassche@acm.org>
Mon, 23 Feb 2026 22:00:14 +0000 (14:00 -0800)
committerGuenter Roeck <linux@roeck-us.net>
Tue, 24 Feb 2026 15:31:35 +0000 (07:31 -0800)
Return early in it87_resume() if it87_lock() fails instead of ignoring the
return value of that function. This patch suppresses a Clang thread-safety
warning.

Cc: Frank Crawford <frank@crawford.emu.id.au>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>
Cc: linux-hwmon@vger.kernel.org
Fixes: 376e1a937b30 ("hwmon: (it87) Add calls to smbus_enable/smbus_disable as required")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20260223220102.2158611-15-bart.vanassche@linux.dev
[groeck: Declare 'ret' at the beginning of it87_resume()]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/it87.c

index e233aafa8856c94c3fde3502732fcda2bd3bf130..5cfb98a0512f003ed99a446040f02cbf5ff6a996 100644 (file)
@@ -3590,10 +3590,13 @@ static int it87_resume(struct device *dev)
 {
        struct platform_device *pdev = to_platform_device(dev);
        struct it87_data *data = dev_get_drvdata(dev);
+       int err;
 
        it87_resume_sio(pdev);
 
-       it87_lock(data);
+       err = it87_lock(data);
+       if (err)
+               return err;
 
        it87_check_pwm(dev);
        it87_check_limit_regs(data);