]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commitdiff
drm/xe/sync: Fix user fence leak on alloc failure
authorShuicheng Lin <shuicheng.lin@intel.com>
Thu, 19 Feb 2026 23:35:19 +0000 (23:35 +0000)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Mon, 23 Feb 2026 21:48:43 +0000 (16:48 -0500)
When dma_fence_chain_alloc() fails, properly release the user fence
reference to prevent a memory leak.

Fixes: 0995c2fc39b0 ("drm/xe: Enforce correct user fence signaling order using")
Cc: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Link: https://patch.msgid.link/20260219233516.2938172-6-shuicheng.lin@intel.com
(cherry picked from commit a5d5634cde48a9fcd68c8504aa07f89f175074a0)
Cc: stable@vger.kernel.org
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_sync.c

index ebf6c96d7a41994fa59a0e638695d81ab1c1afef..24d6d9af20d6fc86598fe6d4f0fb8362882fe6b0 100644 (file)
@@ -206,8 +206,10 @@ int xe_sync_entry_parse(struct xe_device *xe, struct xe_file *xef,
                        if (XE_IOCTL_DBG(xe, IS_ERR(sync->ufence)))
                                return PTR_ERR(sync->ufence);
                        sync->ufence_chain_fence = dma_fence_chain_alloc();
-                       if (!sync->ufence_chain_fence)
-                               return -ENOMEM;
+                       if (!sync->ufence_chain_fence) {
+                               err = -ENOMEM;
+                               goto free_sync;
+                       }
                        sync->ufence_syncobj = ufence_syncobj;
                }