]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
osd/PrimaryLogPG: only filter SnapSet::snaps for flush for pre-octopus compat
authorSage Weil <sage@redhat.com>
Tue, 11 Jun 2019 18:54:45 +0000 (13:54 -0500)
committerSage Weil <sage@redhat.com>
Tue, 2 Jul 2019 13:37:48 +0000 (08:37 -0500)
Signed-off-by: Sage Weil <sage@redhat.com>
src/osd/PrimaryLogPG.cc

index 021fd4ba1ba8071758e8c81d1287d2500ed20ef8..4a6073b85b01a1cf485a89c058f04017eb5742c4 100644 (file)
@@ -9801,8 +9801,15 @@ int PrimaryLogPG::start_flush(
           << " " << (blocking ? "blocking" : "non-blocking/best-effort")
           << dendl;
 
-  // get a filtered snapset, need to remove removed snaps
-  SnapSet snapset = obc->ssc->snapset.get_filtered(pool.info);
+  SnapSet snapset;
+  if (get_osdmap()->require_osd_release >= ceph_release_t::octopus) {
+    // NOTE: change this to a const ref when we remove this compat code
+    snapset = obc->ssc->snapset;
+  } else {
+    // for pre-octopus compatibility, filter SnapSet::snaps.  not
+    // certain we need this, but let's be conservative.
+    snapset = obc->ssc->snapset.get_filtered(pool.info);
+  }
 
   // verify there are no (older) check for dirty clones
   {