Fix firewall check

Use command module instead of shell since we do not do anything fancy
here. Remove the duplicate register.

Signed-off-by: Sébastien Han <seb@redhat.com>

diff --git a/roles/ceph-common/tasks/checks/check_firewall.yml b/roles/ceph-common/tasks/checks/check_firewall.yml
index 632a85605ac737932b82986c62ea0e40a6aa8af3..a04b98e95b279422a5077965eac06968a178d65f 100644 (file)
--- a/roles/ceph-common/tasks/checks/check_firewall.yml
+++ b/roles/ceph-common/tasks/checks/check_firewall.yml
@@ -1,6 +1,6 @@
 ---
 - name: check if nmap is installed
-  shell: "command -v nmap"
+  command: "command -v nmap"
   changed_when: false
   failed_when: false
   register: nmapexist
@@ -16,7 +16,6 @@
   failed_when: false
   with_items: groups.{{ mon_group_name }}
   register: monportstate
-  register: monportstate
   when: mon_group_name in group_names
 
 - name: fail if monitor port is filtered