]> git.apps.os.sepia.ceph.com Git - ceph-cm-ansible.git/commitdiff
Removed check for the packages var in yum/packages.yml
authorAndrew Schoen <aschoen@redhat.com>
Tue, 14 Apr 2015 21:00:17 +0000 (16:00 -0500)
committerAndrew Schoen <aschoen@redhat.com>
Tue, 14 Apr 2015 21:00:17 +0000 (16:00 -0500)
I originally added this to remind me to include the 'vars' tag when
using --tags. However, this isn't necessary once we put the 'always'
tag on vars.yml which makes it run everytime --tags is used.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
roles/testnode/tasks/yum/packages.yml

index 852acc3243231e91bb7b8f24f81f0f506bf499da..f97e536db6b9d5481a7b60e129995bee7f778ef3 100644 (file)
@@ -7,23 +7,12 @@
   tags:
     - remove-ceph
 
-# I added this because when using --tags "packages" the
-# next task will just be skipped because packages == []
-# which is probably an unexpected behavior if you're meaning to
-# install packages.
-- name: Fail the play if the var packages is not defined
-  fail:
-    msg: "The var packages is not defined,
-         perhaps you've forgot to include 'vars' in your
-         tag list if using --tags. Otherwise, check to see
-         if packages needs defining for your specific host."
-  when: packages|length == 0
-
 - name: Install packages
   yum:
     name: "{{ item }}"
     state: present 
   with_items: packages
+  when: packages|length > 0
 
 - name: Remove packages
   yum: