]> git-server-git.apps.pok.os.sepia.ceph.com Git - s3-tests.git/commitdiff
STS issue fix (https://tracker.ceph.com/issues/47588)
authorroot <root@localhost.localdomain>
Mon, 5 Oct 2020 19:05:58 +0000 (00:35 +0530)
committerCasey Bodley <cbodley@redhat.com>
Thu, 8 Oct 2020 17:32:53 +0000 (13:32 -0400)
This is the fix for the issue reported (https://tracker.ceph.com/issues/47588). The issue was with the argument which was passed to the function. After removing that argument (as it's already an optional argument) the issue is fixed.

Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
(cherry picked from commit daf9062a225831a420e471ee0459abc799c45439)

s3tests_boto3/functional/test_sts.py

index 0c66121405977d8d11b1b86378bb32727643ea3b..4799f144e833f7ef74b174dd977989a36f36c0d3 100644 (file)
@@ -86,7 +86,7 @@ def test_get_session_token():
     user_policy = "{\"Version\":\"2012-10-17\",\"Statement\":[{\"Effect\":\"Deny\",\"Action\":\"s3:*\",\"Resource\":[\"*\"],\"Condition\":{\"BoolIfExists\":{\"sts:authentication\":\"false\"}}},{\"Effect\":\"Allow\",\"Action\":\"sts:GetSessionToken\",\"Resource\":\"*\",\"Condition\":{\"BoolIfExists\":{\"sts:authentication\":\"false\"}}}]}"
     (resp_err,resp)=put_user_policy(iam_client,sts_user_id,None,user_policy)
     eq(resp['ResponseMetadata']['HTTPStatusCode'],200)
-    response=sts_client.get_session_token(DurationSeconds=43200)
+    response=sts_client.get_session_token()
     eq(response['ResponseMetadata']['HTTPStatusCode'],200)
     s3_client=boto3.client('s3',
                 aws_access_key_id = response['Credentials']['AccessKeyId'],
@@ -116,7 +116,7 @@ def test_get_session_token_permanent_creds_denied():
     user_policy = "{\"Version\":\"2012-10-17\",\"Statement\":[{\"Effect\":\"Deny\",\"Action\":\"s3:*\",\"Resource\":[\"*\"],\"Condition\":{\"BoolIfExists\":{\"sts:authentication\":\"false\"}}},{\"Effect\":\"Allow\",\"Action\":\"sts:GetSessionToken\",\"Resource\":\"*\",\"Condition\":{\"BoolIfExists\":{\"sts:authentication\":\"false\"}}}]}"
     (resp_err,resp)=put_user_policy(iam_client,sts_user_id,None,user_policy)
     eq(resp['ResponseMetadata']['HTTPStatusCode'],200)
-    response=sts_client.get_session_token(DurationSeconds=43200)
+    response=sts_client.get_session_token()
     eq(response['ResponseMetadata']['HTTPStatusCode'],200)
     s3_client=boto3.client('s3',
                 aws_access_key_id = s3_main_access_key,