]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commitdiff
check: Make the test harness unmount fs when finishing a test
authorXiao Yang <yangx.jy@cn.fujitsu.com>
Tue, 22 May 2018 09:49:59 +0000 (17:49 +0800)
committerEryu Guan <guaneryu@gmail.com>
Wed, 23 May 2018 02:53:04 +0000 (10:53 +0800)
Finishing xfs/132 left a shutdown scratch fs and the test harness
didn't unmount the fs(because we told it not to check the fs) so the
test harness called by subsequent xfs/133 tried to "test -d
$SCRATCH_MNT" and received the IO error from the dead fs.

i.e. Running xfs/132 and xfs/133 together got the following error:
------------------------------------------------------------
...
xfs/132 1s ... 1s
xfs/133 1s ... [failed, exit status 1] - output mismatch (see /var/lib/xfstests/results//xfs/133.out.bad)
...
QA output created by 133
-Format and mount
-Corrupt filesystem
-Remount, try to append
-Write did not succeed (ok).
+SCRATCH_DEV=/dev/sda11 is mounted but not on SCRATCH_MNT=common/config: - aborting
+Already mounted result:
+/dev/sda11 /mnt/xfstests/scratch
...
------------------------------------------------------------

Even if we don't check fs, the test harness is supposed to unmount
fs and return an initial state before running the next test.

Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
check

diff --git a/check b/check
index 96198ac4714ea574330ce08c7464e6e32ef13b23..f6fb352bcbb9553a45b3f1d0d030d0c8b8b2ee78 100755 (executable)
--- a/check
+++ b/check
@@ -489,10 +489,14 @@ _check_filesystems()
        if [ -f ${RESULT_DIR}/require_test ]; then
                _check_test_fs || err=true
                rm -f ${RESULT_DIR}/require_test*
+       else
+               _test_unmount 2> /dev/null
        fi
        if [ -f ${RESULT_DIR}/require_scratch ]; then
                _check_scratch_fs || err=true
                rm -f ${RESULT_DIR}/require_scratch*
+       else
+               _scratch_unmount 2> /dev/null
        fi
 }