]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-cm-ansible.git/commitdiff
common: Comment bad nvme error-log check 393/head
authorDavid Galloway <dgallowa@redhat.com>
Tue, 3 Apr 2018 22:22:08 +0000 (18:22 -0400)
committerDavid Galloway <dgallowa@redhat.com>
Tue, 3 Apr 2018 22:22:08 +0000 (18:22 -0400)
Signed-off-by: David Galloway <dgallowa@redhat.com>
roles/common/files/libexec/smart.sh

index 60db5b9626eeab9a804d9e143e647106164be5f9..19d8aff1e5aa1b2ebe1b18c2a5c2ff86b3a56080 100755 (executable)
@@ -388,12 +388,16 @@ nvme_smart ()
         rc=2
       fi
       # Check for error log entries
-      if [ "$num_err_log_entries" != "0" ]
-      then
-        messages+=("$nvmedisk indicates there are $num_err_log_entries error log entries")
-        failed=true
-        rc=2
-      fi
+#     This doesn't appear to be a useful or reliable method of measuring NVMe health.
+#     I've done a bunch of research and haven't been able to find much of anything
+#     about this metric.  On top of that, all our new reesi NVMe indicate errors but
+#     there's nothing in the error-logs so I'm commenting this for now.
+#      if [ "$num_err_log_entries" != "0" ]
+#      then
+#        messages+=("$nvmedisk indicates there are $num_err_log_entries error log entries")
+#        failed=true
+#        rc=2
+#      fi
     elif [ "$outputcount" != "4" ]
     then
       messages+=("$nvmedisk returned $outputcount of 4 expected attributes")