]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
rgw: initialize RGWIndexCompletionManager thread after related members
authorCasey Bodley <cbodley@redhat.com>
Mon, 7 Mar 2022 20:10:07 +0000 (15:10 -0500)
committerCasey Bodley <cbodley@redhat.com>
Tue, 8 Mar 2022 13:28:35 +0000 (08:28 -0500)
resolves valgrind issues about RGWIndexCompletionManager::process()
using uninitialized memory

Signed-off-by: Casey Bodley <cbodley@redhat.com>
src/rgw/rgw_rados.cc

index 099276d4bd189e305288762c8275f9c913aac8a4..8d790b6a154d3b9f22c7b1ed17b6f526e55cedca 100644 (file)
@@ -811,11 +811,10 @@ class RGWIndexCompletionManager {
   std::vector<set<complete_op_data*>> completions;
   std::vector<complete_op_data*> retry_completions;
 
-  std::thread retry_thread;
   std::condition_variable cond;
   std::mutex retry_completions_lock;
-
   bool _stop{false};
+  std::thread retry_thread;
 
   std::atomic<int> cur_shard {0};