]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commitdiff
Disable dynamic extension support by default for CMake (#5419)
authorYanqin Jin <yanqin@fb.com>
Wed, 5 Jun 2019 20:56:46 +0000 (13:56 -0700)
committerYanqin Jin <yanqin@fb.com>
Wed, 5 Jun 2019 21:09:27 +0000 (14:09 -0700)
Summary:
We have users reporting linking error while building RocksDB using CMake, and we do not enable dynamic extension feature for them. The fix is to add `-DROCKSDB_NO_DYNAMIC_EXTENSION` to CMake by default.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5419

Differential Revision: D15676792

Pulled By: riversand963

fbshipit-source-id: d45aaacfc64ea61646fd7329c352cd760145baf3

CMakeLists.txt

index f4feee986c3e371304a1eb9a00047af3cd0b994b..a3c7a147e53397ab75ebd92360c4caf6b99ad742 100644 (file)
@@ -317,6 +317,10 @@ if(DISABLE_STALL_NOTIF)
   add_definitions(-DROCKSDB_DISABLE_STALL_NOTIFICATION)
 endif()
 
+option(WITH_DYNAMIC_EXTENSION "build with dynamic extension support" OFF)
+if(NOT WITH_DYNAMIC_EXTENSION)
+  add_definitions(-DROCKSDB_NO_DYNAMIC_EXTENSION)
+endif()
 
 if(DEFINED USE_RTTI)
   if(USE_RTTI)