mds: fix up _dispatch ref-counting semantics

Signed-off-by: Greg Farnum <gfarnum@redhat.com>

diff --git a/src/mds/MDSRank.cc b/src/mds/MDSRank.cc
index ac0fb6c825930578142f8634e66c48c036d45b5d..b6e0c1b95dd8fb1728e01e407ab0e4ce6e106447 100644 (file)
--- a/src/mds/MDSRank.cc
+++ b/src/mds/MDSRank.cc
@@ -418,8 +418,8 @@ bool MDSRankDispatcher::ms_dispatch(Message *m)
   return ret;
 }
 
-/* If this function returns true, it has put the message. If it returns false,
- * it has not put the message. */
+/* If this function returns true, it recognizes the message and has taken the
+ * reference. If it returns false, it has done neither. */
 bool MDSRank::_dispatch(Message *m, bool new_msg)
 {
   if (is_stale_message(m)) {
@@ -436,7 +436,6 @@ bool MDSRank::_dispatch(Message *m, bool new_msg)
   } else {
     if (!handle_deferrable_message(m)) {
       dout(0) << "unrecognized message " << *m << dendl;
-      m->put();
       return false;
     }
   }