]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
rgw: reject bucket tagging requests and document unsupported
authorCasey Bodley <cbodley@redhat.com>
Thu, 14 Mar 2019 13:27:36 +0000 (09:27 -0400)
committerCasey Bodley <cbodley@redhat.com>
Fri, 22 Mar 2019 14:12:07 +0000 (10:12 -0400)
Signed-off-by: Casey Bodley <cbodley@redhat.com>
doc/radosgw/s3.rst
src/rgw/rgw_rest_s3.cc
src/rgw/rgw_rest_s3.h

index cf6eaba7fa4da55997919f8b8e6353348bb56f07..d1d4b6b53193e9cd6311a5d1d2867abb1087543a 100644 (file)
@@ -74,6 +74,8 @@ The following table describes the support status for current Amazon S3 functiona
 +---------------------------------+-----------------+----------------------------------------+
 | **Object Tagging**              | Supported       | See :ref:`tag_policy` for Policy verbs |
 +---------------------------------+-----------------+----------------------------------------+
+| **Bucket Tagging**              | Not Supported   |                                        |
++---------------------------------+-----------------+----------------------------------------+
 | **Storage Class**               | Supported       | See :ref:`storage_classes`             |
 +---------------------------------+-----------------+----------------------------------------+
 
index be1c3fe6c430f22dc1807b8b2a06ca92b4c9bf49..a5cb4c8ee3ba34c55e1ced6c10315259bb4f70d5 100644 (file)
@@ -3196,6 +3196,8 @@ RGWOp *RGWHandler_REST_Bucket_S3::op_put()
     return new RGWPutLC_ObjStore_S3;
   } else if(is_policy_op()) {
     return new RGWPutBucketPolicy;
+  } else if (is_tagging_op()) {
+    return nullptr;
   }
   return new RGWCreateBucket_ObjStore_S3;
 }
index 0c5ab184ddddcf36c43f18f6a8300ef5f5a31b95..9d3e7311b9ab6eb5ec787547645bc13eb659dcc1 100644 (file)
@@ -555,6 +555,9 @@ protected:
   bool is_policy_op() {
     return s->info.args.exists("policy");
   }
+  bool is_tagging_op() const {
+    return s->info.args.exists("tagging");
+  }
   RGWOp *get_obj_op(bool get_data);
 
   RGWOp *op_get() override;