]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commitdiff
Fix flaky test DBTest2.VariousFileTemperatures (#12974) v9.6.1
authorPeter Dillinger <peterd@meta.com>
Mon, 26 Aug 2024 21:08:21 +0000 (14:08 -0700)
committerPeter Dillinger <peterd@meta.com>
Tue, 27 Aug 2024 20:39:35 +0000 (13:39 -0700)
Summary:
... apparently due to potentially not purging obsolete files after CompactRange

Example: https://github.com/facebook/rocksdb/actions/runs/10564621261/job/29267393711?pr=12959

Pull Request resolved: https://github.com/facebook/rocksdb/pull/12974

Test Plan: reproduced failure with USE_CLANG=1 COERCE_CONTEXT_SWITCH=1, now fixed

Reviewed By: cbi42

Differential Revision: D61812600

Pulled By: pdillinger

fbshipit-source-id: d4b23e1a179bb8ec39875ed7a8ce1649fa3344bd

db/db_test2.cc

index f380144c6ab3e994a8e856542401cc45f1fddd0c..92211ad42ddde755ab1faaea3b0f8c930e98f3d6 100644 (file)
@@ -6739,6 +6739,7 @@ TEST_F(DBTest2, VariousFileTemperatures) {
                 TCM({{options.default_write_temperature, 2}}));
 
       ASSERT_OK(db_->CompactRange({}, nullptr, nullptr));
+      ASSERT_OK(dbfull()->TEST_WaitForBackgroundWork());
 
       ASSERT_EQ(test_fs->CountCurrentSstFilesByTemp(),
                 TCM({{options.last_level_temperature, 1}}));