]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
mon: NULL check of logger before use
authoramitkuma <amitkuma@redhat.com>
Tue, 7 Nov 2017 17:00:27 +0000 (22:30 +0530)
committeramitkuma <amitkuma@redhat.com>
Mon, 20 Nov 2017 13:59:32 +0000 (19:29 +0530)
Fixes the coverity issue:
CID 1316234 (#1 of 1): Dereference after null check (FORWARD_NULL)
6. var_deref_model: remove_session dereferences null this->logger

Signed-off-by: Amit Kumar <amitkuma@redhat.com>
src/mon/Monitor.cc

index 41b19bb6a78702513315d6f4970f1f0700a81cf8..f53cf7c3d5ed1a4b05e318c848c90f752c3400ca 100644 (file)
@@ -3832,8 +3832,7 @@ void Monitor::remove_all_sessions()
   while (!session_map.sessions.empty()) {
     MonSession *s = session_map.sessions.front();
     remove_session(s);
-    if (logger)
-      logger->inc(l_mon_session_rm);
+    logger->inc(l_mon_session_rm);
   }
   if (logger)
     logger->set(l_mon_num_sessions, session_map.get_size());