mds: Refactor Mantle::balance to use std::string instead of std::string_view for...

Fixes: https://tracker.ceph.com/issues/73429
Signed-off-by: Edwin Rodriguez <edwin.rodriguez1@ibm.com>

diff --git a/src/mds/Mantle.cc b/src/mds/Mantle.cc
index 5a03312c5b14d11ff3e78eaa17419efbc936fcaa..c6c19a7ae090b420e0ad8e317cd2f73d431850fa 100644 (file)
--- a/src/mds/Mantle.cc
+++ b/src/mds/Mantle.cc
@@ -49,15 +49,17 @@ static int dout_wrapper(lua_State *L)
   return 0;
 }
 
-int Mantle::balance(std::string_view script,
-                    mds_rank_t whoami,
-                    const std::vector<std::map<std::string, double>> &metrics,
-                    std::map<mds_rank_t, double> &my_targets)
+int
+Mantle::balance(
+    const std::string& script,
+    mds_rank_t whoami,
+    const std::vector<std::map<std::string, double>>& metrics,
+    std::map<mds_rank_t, double>& my_targets)
 {
   lua_settop(L, 0); /* clear the stack */
 
   /* load the balancer */
-  if (luaL_loadstring(L, script.data())) {
+  if (luaL_loadstring(L, script.c_str())) {
     mantle_dout(0) << "WARNING: mantle could not load balancer: "
             << lua_tostring(L, -1) << mantle_dendl;
     return -EINVAL;

diff --git a/src/mds/Mantle.h b/src/mds/Mantle.h
index 17c7807b17a3145ed414dd372a460a37c320c478..2eaa9ab3072a054eb4e607d8332642b2be409824 100644 (file)
--- a/src/mds/Mantle.h
+++ b/src/mds/Mantle.h
@@ -30,11 +30,14 @@
 class Mantle {
   public:
     Mantle();
-    ~Mantle() { if (L) lua_close(L); }
-    int balance(std::string_view script,
-                mds_rank_t whoami,
-                const std::vector <std::map<std::string, double>> &metrics,
-                std::map<mds_rank_t,double> &my_targets);
+    ~Mantle() { if (L) lua_close(L);
+    }
+
+    int balance(
+        const std::string& script,
+        mds_rank_t whoami,
+        const std::vector<std::map<std::string, double>>& metrics,
+        std::map<mds_rank_t, double>& my_targets);
 
   protected:
     lua_State *L;