]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
osd/scrub: use std::ssize() to avoid narrowing conversions
authorRonen Friedman <rfriedma@redhat.com>
Thu, 14 Mar 2024 16:15:55 +0000 (11:15 -0500)
committerRonen Friedman <rfriedma@redhat.com>
Fri, 15 Mar 2024 14:04:04 +0000 (09:04 -0500)
using std::ssize() to avoid a narrowing conversion when using
the size of a container as a parameter to a function expecting
an int64_t.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
src/osd/scrubber/pg_scrubber.cc
src/osd/scrubber/scrub_reservations.cc

index 9fe7295201d69036bd0879df6d1f01ce92659e43..e1604222c2c936cdc4f9311567fc846da7eee1b1 100644 (file)
@@ -1504,7 +1504,7 @@ void PgScrubber::apply_snap_mapper_fixes(
 
 void PgScrubber::maps_compare_n_cleanup()
 {
-  m_pg->add_objects_scrubbed_count(m_be->get_primary_scrubmap().objects.size());
+  m_pg->add_objects_scrubbed_count(std::ssize(m_be->get_primary_scrubmap().objects));
 
   auto required_fixes =
     m_be->scrub_compare_maps(m_end.is_max(), get_snap_mapper_accessor());
index 918bf4869254804cf32ec649ae361e1b612a545c..d52c10456aab075e678cd57db25d2c829f3cbfc3 100644 (file)
@@ -103,7 +103,7 @@ void ReplicaReservations::log_success_and_duration()
   m_perf_set.tinc(scrbcnt_resrv_successful_elapsed, logged_duration);
   m_perf_set.inc(scrbcnt_resrv_success);
   m_osds->logger->hinc(
-      l_osd_scrub_reservation_dur_hist, m_sorted_secondaries.size(),
+      l_osd_scrub_reservation_dur_hist, std::ssize(m_sorted_secondaries),
       logged_duration.count());
   m_process_started_at.reset();
 }