]> git.apps.os.sepia.ceph.com Git - ceph-build.git/commitdiff
scripts/build_utils: remove Debug build from Crimson 2367/head
authorMatan Breizman <mbreizma@redhat.com>
Sun, 18 May 2025 08:40:52 +0000 (11:40 +0300)
committerMatan Breizman <mbreizma@redhat.com>
Sun, 18 May 2025 08:40:52 +0000 (11:40 +0300)
See: https://github.com/ceph/ceph-build/pull/2167/files
Builds should be set to Debug only when ending in "-debug".

https://github.com/ceph/ceph-build/pull/1805 set Crimson to always use Debug.
That made sense in earlier development phases.
However, today we should align with Classical builds and use Debug only when needed.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
ceph-source-dist/build/Jenkinsfile
scripts/build_utils.sh

index 6b1f138271874c34cbc0112d3ae75e61137dc079..e08a838e2472aceb523ffa623a94a470b316b21e 100644 (file)
@@ -14,8 +14,7 @@ pipeline {
               env.DEB_BUILD_PROFILES=""
               break
             case "crimson":
-              env.CEPH_EXTRA_RPMBUILD_ARGS="--with seastar"
-              env.CEPH_EXTRA_CMAKE_ARGS+=" -DCMAKE_BUILD_TYPE=Debug"
+              env.CEPH_EXTRA_RPMBUILD_ARGS="--with crimson"
               env.DEB_BUILD_PROFILES="pkg.ceph.crimson"
               break
             case "jaeger":
index d1d32221e7567cd94498a5f17e97725528c26768..d6da4d6995b766b61b0a36200c8ad08d39d4ee16 100755 (executable)
@@ -869,7 +869,6 @@ ceph_build_args_from_flavor() {
         ;;
     crimson)
         CEPH_EXTRA_RPMBUILD_ARGS="--with crimson"
-        CEPH_EXTRA_CMAKE_ARGS+=" -DCMAKE_BUILD_TYPE=Debug"
         DEB_BUILD_PROFILES="pkg.ceph.crimson"
         ;;
     jaeger)