]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commitdiff
common: Re-enable testing over NFS
authorAnna Schumaker <Anna.Schumaker@netapp.com>
Tue, 14 Oct 2014 11:59:38 +0000 (22:59 +1100)
committerDave Chinner <david@fromorbit.com>
Tue, 14 Oct 2014 11:59:38 +0000 (22:59 +1100)
83ef157 (common: Check fs consistency on TEST_DEV only when needed) has
_require_test unconditionally return _notrun when testing on an NFS
filesystem, essentially disabling NFS.  This patch changes the code to
validate $TEST_DEV and only call _notrun if validation fails.

Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
common/rc

index 3d366db65a4b5fa9805d8858766a9c790ff32427..747cf72cfc1582064859f02fd859a4a8b5bc1ad2 100644 (file)
--- a/common/rc
+++ b/common/rc
@@ -1092,8 +1092,14 @@ _require_test()
 {
     case "$FSTYP" in
        nfs*)
-                 _notrun "requires a test device"
-                ;;
+               echo $TEST_DEV | grep -q ":/" > /dev/null 2>&1
+               if [ -z "$TEST_DEV" -o "$?" != "0" ]; then
+                       _notrun "this test requires a valid \$TEST_DIR"
+               fi
+               if [ ! -d "$TEST_DIR" ]; then
+                       _notrun "this test requires a valid \$TEST_DIR"
+               fi
+               ;;
        cifs)
                echo $TEST_DEV | grep -q "//" > /dev/null 2>&1
                if [ -z "$TEST_DEV" -o "$?" != "0" ]; then