]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
crimson/admin: s/perf dump_seastar/dump_metrics/
authorKefu Chai <kchai@redhat.com>
Thu, 3 Jun 2021 05:45:05 +0000 (13:45 +0800)
committerKefu Chai <kchai@redhat.com>
Thu, 3 Jun 2021 05:59:21 +0000 (13:59 +0800)
as a user-facing interface, no need to expose seastar in the name,
what matters to user is the content not the underlying technology or library.

so rename the command prefix to "dump_metrics"

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/crimson/admin/osd_admin.cc

index cea9bdb959be0204a6f62abfcd4f01d5c7f11c9c..16df274b3253d81786fa1a02fab9e863b66ef912 100644 (file)
@@ -200,7 +200,7 @@ template std::unique_ptr<AdminSocketHook> make_asok_hook<AssertAlwaysHook>();
 class DumpMetricsHook : public AdminSocketHook {
 public:
   DumpMetricsHook() :
-    AdminSocketHook("perf dump_seastar",
+    AdminSocketHook("dump_metrics",
                     "name=group,type=CephString,req=false",
                     "dump current configured seastar metrics and their values")
   {}
@@ -211,7 +211,7 @@ public:
     std::unique_ptr<Formatter> f{Formatter::create(format, "json-pretty", "json-pretty")};
     std::string prefix;
     cmd_getval(cmdmap, "group", prefix);
-    f->open_object_section("perf_dump_seastar");
+    f->open_object_section("metrics");
     for (const auto& [full_name, metric_family]: seastar::scollectd::get_value_map()) {
       if (!prefix.empty() && full_name.compare(0, prefix.size(), prefix) != 0) {
        continue;