]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
crimson: do not capture unused variables
authorKefu Chai <kchai@redhat.com>
Thu, 16 Jul 2020 12:40:16 +0000 (20:40 +0800)
committerKefu Chai <kchai@redhat.com>
Thu, 16 Jul 2020 12:49:28 +0000 (20:49 +0800)
this change silences warnings like:

mson/osd/backfill_state.cc:131:11: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
      [&, this](const pg_log_entry_t& e) {
        ~~^~~~

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/crimson/osd/backfill_state.cc
src/crimson/osd/osd.cc

index 7c66013e18c9906d54f4aae70ebd7acc52c844ff..1ffadd4e8483ca127e9a8d74831f135155d48916 100644 (file)
@@ -128,7 +128,7 @@ void BackfillState::Enqueuing::maybe_update_range()
                    pg().get_projected_last_update());
     logger().debug("{}: scanning pg log first", __func__);
     peering_state().get_pg_log().get_log().scan_log_after(primary_bi.version,
-      [&, this](const pg_log_entry_t& e) {
+      [&](const pg_log_entry_t& e) {
         logger().debug("maybe_update_range(lambda): updating from version {}",
                        e.version);
         if (e.soid >= primary_bi.begin && e.soid <  primary_bi.end) {
@@ -198,7 +198,7 @@ bool BackfillState::Enqueuing::should_rescan_replicas(
 {
   const auto& targets = peering_state().get_backfill_targets();
   return std::any_of(std::begin(targets), std::end(targets),
-    [&, this] (const auto& bt) {
+    [&] (const auto& bt) {
       return ReplicasScanning::replica_needs_scan(peer_backfill_info.at(bt),
                                                   backfill_info);
     });
@@ -218,7 +218,7 @@ void BackfillState::Enqueuing::trim_backfilled_object_from_intervals(
   std::map<pg_shard_t, BackfillInterval>& peer_backfill_info)
 {
   std::for_each(std::begin(result.pbi_targets), std::end(result.pbi_targets),
-    [this, &peer_backfill_info] (const auto& bt) {
+    [&peer_backfill_info] (const auto& bt) {
       peer_backfill_info.at(bt).pop_front();
     });
   last_backfill_started = std::move(result.new_last_backfill_started);
index e4fb16cc9f11ec696afb353eff44c024d2a33e1d..8f6b14ec72e84b389a30a49cba9ddc4c3863e233 100644 (file)
@@ -1055,7 +1055,7 @@ seastar::future<> OSD::send_incremental_map(crimson::net::Connection* conn,
     });
   } else {
     return load_map_bl(osdmap->get_epoch())
-    .then([this, conn, first](auto&& bl) mutable {
+    .then([this, conn](auto&& bl) mutable {
       auto m = make_message<MOSDMap>(monc->get_fsid(),
          osdmap->get_encoding_features());
       m->oldest_map = superblock.oldest_map;