mgr/dashboard: Clean the output of lint and fix scripts

Increase deprecation tslint rule from warning to error and
remove no-use-before-declare.

Fixes: https://tracker.ceph.com/issues/46339
Signed-off-by: Tiago Melo <tmelo@suse.com>

diff --git a/src/pybind/mgr/dashboard/frontend/package.json b/src/pybind/mgr/dashboard/frontend/package.json
index ae40091954e50609cf82a1468fd123c15a9d51af..ef0e8078f75dd2bb926f8330fb17fcb828740929 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/package.json
+++ b/src/pybind/mgr/dashboard/frontend/package.json
@@ -27,12 +27,12 @@
     "lint:html": "htmllint src/app/**/*.html && html-linter --config html-linter.config.json",
     "lint:tsc": "tsc -p src/tsconfig.app.json --noEmit && tsc -p tsconfig.spec.json --noEmit && tsc -p cypress/tsconfig.json --noEmit",
     "lint:scss": "stylelint '**/*.scss'",
-    "lint": "run-p --continue-on-error --aggregate-output lint:*",
+    "lint": "run-p -csl --aggregate-output lint:*",
     "fix:prettier": "prettier --write \"{src,cypress}/**/*.{ts,scss}\"",
     "fix:tslint": "npm run lint:tslint -- --fix",
     "fix:scss": "stylelint '**/*.scss' --fix",
     "fixmod": "pretty-quick --pattern \"{src,cypress}/**/*.{ts,scss}\" --branch HEAD",
-    "fix": "run-p --continue-on-error --aggregate-output fix:*",
+    "fix": "run-p -csl --aggregate-output fix:*",
     "fix:audit": "npx npm-force-resolutions",
     "compodoc": "compodoc",
     "doc-build": "compodoc -p src/tsconfig.app.json",

diff --git a/src/pybind/mgr/dashboard/frontend/tslint.json b/src/pybind/mgr/dashboard/frontend/tslint.json
index 4b14fc5c5f583ec92cdb7444fc775cda55f0bef2..5136dc651af55a31c909368c86b83414ea97c504 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/tslint.json
+++ b/src/pybind/mgr/dashboard/frontend/tslint.json
@@ -8,7 +8,7 @@
     "comment-format": [true, "check-space"],
     "curly": true,
     "deprecation": {
-      "severity": "warning"
+      "severity": "error"
     },
     "eofline": true,
     "forin": true,
@@ -44,7 +44,6 @@
     "no-trailing-whitespace": true,
     "no-unnecessary-initializer": true,
     "no-unused-expression": true,
-    "no-use-before-declare": true,
     "no-var-keyword": true,
     "object-literal-sort-keys": false,
     "one-line": [true, "check-open-brace", "check-catch", "check-else", "check-whitespace"],