]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commitdiff
xfs/{080,329,434,436}: add missing check for fallocate support
authorDarrick J. Wong <djwong@kernel.org>
Wed, 18 Jan 2023 00:43:16 +0000 (16:43 -0800)
committerZorro Lang <zlang@kernel.org>
Fri, 20 Jan 2023 13:27:41 +0000 (21:27 +0800)
Don't run this test if the filesystem doesn't support fallocate.  This
is only ever the case if always_cow is enabled.

The same logic applies to xfs/329, though it's more subtle because the
test itself does not explicitly invoke fallocate; rather, it is xfs_fsr
that requires fallocate.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Zorro Lang <zlang@kernel.org>
tests/xfs/080
tests/xfs/329
tests/xfs/434
tests/xfs/436

index 20b20a08ebb8e71a734de8ea8e2313b6ad64c9e2..abcfa004b5476855ccc6e1e00bca516a36a946f9 100755 (executable)
@@ -21,6 +21,7 @@ _cleanup()
 
 _supported_fs xfs
 _require_test
+_require_xfs_io_command falloc # iogen requires falloc
 
 quiet=-q
 clean=-c
index 4cad686c174759e313fcd25ce057a60f7358e6cf..15dc3c242f92ba76e30bb6fac9897c4569439321 100755 (executable)
@@ -22,6 +22,7 @@ _require_cp_reflink
 _require_command "$XFS_FSR_PROG" "xfs_fsr"
 _require_xfs_io_error_injection "bmap_finish_one"
 _require_xfs_scratch_rmapbt
+_require_xfs_io_command falloc # fsr requires support for preallocation
 
 rm -f "$seqres.full"
 
index 576f1b0e1e9caf6c533687cd4b7233da79403df9..de52531053e1dbb60d4897fc17fb21dc19f13094 100755 (executable)
@@ -35,6 +35,7 @@ _require_quota
 _require_scratch_reflink
 _require_cp_reflink
 _require_command "$XFS_FSR_PROG" "xfs_fsr"
+_require_xfs_io_command falloc # fsr requires support for preallocation
 _require_xfs_io_error_injection "bmap_finish_one"
 _require_xfs_scratch_rmapbt
 
index 9e6ec9372d994c4e1811f5ec04aa236fb0f2745e..b95da8abf4e0a1dbb0282b8b4cbd3c7da8685246 100755 (executable)
@@ -30,6 +30,7 @@ _supported_fs xfs
 _require_loadable_fs_module "xfs"
 _require_scratch_reflink
 _require_cp_reflink
+_require_xfs_io_command falloc # fsr requires support for preallocation
 _require_command "$XFS_FSR_PROG" "xfs_fsr"
 _require_xfs_io_error_injection "bmap_finish_one"
 _require_xfs_scratch_rmapbt