Fix rubocop deprecated conf

Fix rubocop version in Gemfile

diff --git a/.rubocop.yml b/.rubocop.yml
index c739e34c4a8ecf9f96f0f73d73b4e151deb44b1f..efd868603451a6291e643af0d5318594aa3da0c7 100644 (file)
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -22,11 +22,11 @@ MethodLength:
   Enabled: false
 SignalException:
   Enabled: false
-TrailingComma:
-  Enabled: false
 WordArray:
   Enabled: false
 Metrics/AbcSize:
   Enabled: false
 Metrics/PerceivedComplexity:
   Enabled: false
+ConditionalAssignment:
+  Enabled: false

diff --git a/.travis.yml b/.travis.yml
index 232d1a5916bc3de91cc9b25fddef6c32af1f46d9..44f064771f415ff02982da0c199337a7a39f96dc 100644 (file)
--- a/.travis.yml
+++ b/.travis.yml
@@ -3,7 +3,6 @@ sudo: false
 cache: bundler
 bundler_args: --without kitchen_common kitchen_vagrant
 rvm:
-  - 2.0
   - 2.1
   - 2.2
 script:

diff --git a/Gemfile b/Gemfile
index 55080daf23d731b5b2680bbcb274d50fd478f7ba..fec53117fd7e99bef4dc586ed04877b859c26667 100644 (file)
--- a/Gemfile
+++ b/Gemfile
@@ -2,7 +2,7 @@ source 'https://rubygems.org'
 
 group :lint do
   gem 'foodcritic', '~> 4.0'
-  gem 'rubocop', '~> 0.33'
+  gem 'rubocop', '~> 0.40.0'
 end
 
 group :unit do

diff --git a/libraries/default.rb b/libraries/default.rb
index 297da3753734b3a77f78fe925c845b9d32d2b98e..e51ac7c5ddc93d7ba9a9d3b233ad438652d8c7b7 100644 (file)
--- a/libraries/default.rb
+++ b/libraries/default.rb
@@ -91,10 +91,11 @@ end
 
 def ip_address_to_ceph_address(ip, params)
   if params['family'].eql?('inet')
-    return "#{ip}:6789"
+    "#{ip}:6789"
   elsif params['family'].eql?('inet6')
-    return "[#{ip}]:6789"
+    "[#{ip}]:6789"
   end
+  nil
 end
 
 def mon_addresses
@@ -110,15 +111,13 @@ def mon_addresses
     mons << node if node['ceph']['is_mon']
 
     mons += mon_nodes
-    if crowbar?
-      mon_ips = mons.map { |node| Chef::Recipe::Barclamp::Inventory.get_network_by_type(node, 'admin').address }
-    else
-      if node['ceph']['config']['global'] && node['ceph']['config']['global']['public network']
-        mon_ips = mons.map { |nodeish| find_node_ip_in_network(node['ceph']['config']['global']['public network'], nodeish) }
-      else
-        mon_ips = mons.map { |node| node['ipaddress'] + ':6789' }
-      end
-    end
+    mon_ips = if crowbar?
+                mons.map { |node| Chef::Recipe::Barclamp::Inventory.get_network_by_type(node, 'admin').address }
+              elsif node['ceph']['config']['global'] && node['ceph']['config']['global']['public network']
+                mons.map { |nodeish| find_node_ip_in_network(node['ceph']['config']['global']['public network'], nodeish) }
+              else
+                mons.map { |node| node['ipaddress'] + ':6789' }
+              end
   end
   mon_ips.reject(&:nil?).uniq
 end

diff --git a/providers/client.rb b/providers/client.rb
index 548b76b21910d55600b620ebb821b0002ad48e09..25e3716122c294c6c523cddd03baa00d29a65c35 100644 (file)
--- a/providers/client.rb
+++ b/providers/client.rb
@@ -53,7 +53,7 @@ def load_current_resource
   @current_resource.key(get_key(@current_resource.keyname))
   @current_resource.caps_match = @current_resource.caps == @new_resource.caps
   @current_resource.keys_match = @new_resource.key.nil? || (@current_resource.key == @new_resource.key)
-  @current_resource.exists = ! (@current_resource.key.nil? || @current_resource.key.empty?)
+  @current_resource.exists = !(@current_resource.key.nil? || @current_resource.key.empty?)
 end
 
 def file_content(keyname, key, as_keyring)

diff --git a/recipes/apt.rb b/recipes/apt.rb
index b5720fb463d83efff106301c94049b911d8a5ea6..278a7ffe7ee337ce3467a4079b9c0c0edfceb5c3 100644 (file)
--- a/recipes/apt.rb
+++ b/recipes/apt.rb
@@ -4,10 +4,10 @@ include_recipe 'apt'
 branch = node['ceph']['branch']
 
 distribution_codename =
-case node['lsb']['codename']
-when 'jessie' then 'sid'
-else node['lsb']['codename']
-end
+  case node['lsb']['codename']
+  when 'jessie' then 'sid'
+  else node['lsb']['codename']
+  end
 
 apt_preference 'ceph_repo' do
   glob '*'

diff --git a/recipes/osd.rb b/recipes/osd.rb
index d07f16112a795ef543f491d99e2e6540230be4c4..5b4e490fe6c9bbde128ddf3e7d5996f725b18c06 100644 (file)
--- a/recipes/osd.rb
+++ b/recipes/osd.rb
@@ -81,7 +81,7 @@ if crowbar?
     command 'udevadm trigger --subsystem-match=block --action=add'
     action :nothing
   end
-else
+
   # Calling ceph-disk-prepare is sufficient for deploying an OSD
   # After ceph-disk-prepare finishes, the new device will be caught
   # by udev which will run ceph-disk-activate on it (udev will map
@@ -91,60 +91,59 @@ else
   # osd/$cluster-$id)
   #  - $cluster should always be ceph
   #  - The --dmcrypt option will be available starting w/ Cuttlefish
-  if node['ceph']['osd_devices']
-    devices = node['ceph']['osd_devices']
+elsif node['ceph']['osd_devices']
+  devices = node['ceph']['osd_devices']
 
-    devices = Hash[(0...devices.size).zip devices] unless devices.is_a? Hash
+  devices = Hash[(0...devices.size).zip devices] unless devices.is_a? Hash
 
-    devices.each do |index, osd_device|
-      unless osd_device['status'].nil?
-        Log.info("osd: osd_device #{osd_device} has already been setup.")
-        next
-      end
+  devices.each do |index, osd_device|
+    unless osd_device['status'].nil?
+      Log.info("osd: osd_device #{osd_device} has already been setup.")
+      next
+    end
 
-      directory osd_device['device'] do # ~FC022
-        owner 'root'
-        group 'root'
-        recursive true
-        only_if { osd_device['type'] == 'directory' }
-      end
+    directory osd_device['device'] do # ~FC022
+      owner 'root'
+      group 'root'
+      recursive true
+      only_if { osd_device['type'] == 'directory' }
+    end
 
-      dmcrypt = osd_device['encrypted'] == true ? '--dmcrypt' : ''
+    dmcrypt = osd_device['encrypted'] == true ? '--dmcrypt' : ''
 
-      execute "ceph-disk-prepare on #{osd_device['device']}" do
-        command "ceph-disk-prepare #{dmcrypt} #{osd_device['device']} #{osd_device['journal']}"
-        action :run
-        notifies :create, "ruby_block[save osd_device status #{index}]", :immediately
-      end
+    execute "ceph-disk-prepare on #{osd_device['device']}" do
+      command "ceph-disk-prepare #{dmcrypt} #{osd_device['device']} #{osd_device['journal']}"
+      action :run
+      notifies :create, "ruby_block[save osd_device status #{index}]", :immediately
+    end
 
-      execute "ceph-disk-activate #{osd_device['device']}" do
-        only_if { osd_device['type'] == 'directory' }
-      end
+    execute "ceph-disk-activate #{osd_device['device']}" do
+      only_if { osd_device['type'] == 'directory' }
+    end
 
-      # we add this status to the node env
-      # so that we can implement recreate
-      # and/or delete functionalities in the
-      # future.
-      ruby_block "save osd_device status #{index}" do
-        block do
-          node.normal['ceph']['osd_devices'][index]['status'] = 'deployed'
-          node.save
-        end
-        action :nothing
+    # we add this status to the node env
+    # so that we can implement recreate
+    # and/or delete functionalities in the
+    # future.
+    ruby_block "save osd_device status #{index}" do
+      block do
+        node.normal['ceph']['osd_devices'][index]['status'] = 'deployed'
+        node.save
       end
+      action :nothing
     end
-    service 'ceph_osd' do
-      case service_type
-      when 'upstart'
-        service_name 'ceph-osd-all-starter'
-        provider Chef::Provider::Service::Upstart
-      else
-        service_name 'ceph'
-      end
-      action [:enable, :start]
-      supports :restart => true
+  end
+  service 'ceph_osd' do
+    case service_type
+    when 'upstart'
+      service_name 'ceph-osd-all-starter'
+      provider Chef::Provider::Service::Upstart
+    else
+      service_name 'ceph'
     end
-  else
-    Log.info('node["ceph"]["osd_devices"] empty')
+    action [:enable, :start]
+    supports :restart => true
   end
+else
+  Log.info('node["ceph"]["osd_devices"] empty')
 end

diff --git a/recipes/tgt.rb b/recipes/tgt.rb
index eb353e9009a0da1dde3af5cd657e617a71e24495..821262dab223f961988a7a888dd6395019ecc6d0 100644 (file)
--- a/recipes/tgt.rb
+++ b/recipes/tgt.rb
@@ -42,10 +42,8 @@ service 'tgt' do
   if node['platform'] == 'ubuntu'
     # The ceph version of tgt does not provide an Upstart script
     provider Chef::Provider::Service::Init::Debian
-    service_name 'tgt'
-  else
-    service_name 'tgt'
   end
+  service_name 'tgt'
   supports :restart => true
   action [:enable, :start]
 end