make sure you do not allow single IPs for new

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>

diff --git a/ceph_deploy/util/arg_validators.py b/ceph_deploy/util/arg_validators.py
index 20db57ef6d219d51724a9aef8d5c8ce170cbba19..422bba3b9cd0da3b6de8113bb3845fc6803b1eb5 100644 (file)
--- a/ceph_deploy/util/arg_validators.py
+++ b/ceph_deploy/util/arg_validators.py
@@ -34,11 +34,21 @@ class Hostname(object):
         self.socket = _socket or socket  # just used for testing
 
     def __call__(self, string):
-        host = string.split(':')[-1]  # we might have name:host
+        parts = string.split(':')
+        name = parts[0]
+        host = parts[-1]
         try:
-            resolved_addr = self.socket.gethostbyname(host)
+            self.socket.gethostbyname(host)
         except self.socket.gaierror:
             msg = "hostname: %s is not resolvable" % host
             raise argparse.ArgumentError(None, msg)
 
+        try:
+            self.socket.inet_aton(name)
+        except self.socket.error:
+            return string  # not an IP
+        else:
+            msg = '%s must be a hostname not an IP' % name
+            raise argparse.ArgumentError(None, msg)
+
         return string