library: remove unused module import

Move the import at the top of the file and remove unused module import.

- E402 module level import not at top of file
- F401 'xxxx' imported but unused

This also removes the '# noqa E402' statement from the code.

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>

diff --git a/library/ceph_dashboard_user.py b/library/ceph_dashboard_user.py
index db4a267402345db3337b3d519d31cf857024b7df..b2101ccc57f1743effe949d070777897ed02d37a 100644 (file)
--- a/library/ceph_dashboard_user.py
+++ b/library/ceph_dashboard_user.py
@@ -15,6 +15,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -99,13 +104,6 @@ EXAMPLES = '''
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa E402
-import datetime  # noqa E402
-import json  # noqa E402
-import os  # noqa E402
-import stat  # noqa E402
-import time  # noqa E402
-
 
 def container_exec(binary, container_image):
     '''

diff --git a/library/ceph_fs.py b/library/ceph_fs.py
index 01f0a26e9e10eeaae6cd2753cd0c99cde6ffe835..d16210307595f3fedca8bbcea571d08598e8fda1 100644 (file)
--- a/library/ceph_fs.py
+++ b/library/ceph_fs.py
@@ -15,6 +15,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -91,13 +96,6 @@ EXAMPLES = '''
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa E402
-import datetime  # noqa E402
-import json  # noqa E402
-import os  # noqa E402
-import stat  # noqa E402
-import time  # noqa E402
-
 
 def container_exec(binary, container_image):
     '''

diff --git a/library/ceph_key.py b/library/ceph_key.py
index 2be37ed84a8a3c2e7b005d6f8ad276d01e8a6b23..e87ac225986716a468a5854b45b0a500714c65a0 100644 (file)
--- a/library/ceph_key.py
+++ b/library/ceph_key.py
@@ -17,6 +17,15 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+import struct
+import time
+import base64
+import socket
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -187,17 +196,6 @@ caps:
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa E402
-import datetime  # noqa E402
-import grp  # noqa E402
-import json  # noqa E402
-import os  # noqa E402
-import pwd  # noqa E402
-import stat  # noqa E402
-import struct  # noqa E402
-import time  # noqa E402
-import base64  # noqa E402
-import socket  # noqa E402
 
 CEPH_INITIAL_KEYS = ['client.admin', 'client.bootstrap-mds', 'client.bootstrap-mgr',  # noqa E501
                      'client.bootstrap-osd', 'client.bootstrap-rbd', 'client.bootstrap-rbd-mirror', 'client.bootstrap-rgw']  # noqa E501

diff --git a/library/ceph_pool.py b/library/ceph_pool.py
index 4104fdfda2f6a837a5cfe7baadcc9a7a00c3b4ab..31ed193a797ef6733866d2db3f7cb29345d21aac 100644 (file)
--- a/library/ceph_pool.py
+++ b/library/ceph_pool.py
@@ -17,6 +17,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -135,13 +140,6 @@ pools:
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa E402
-import datetime  # noqa E402
-import json  # noqa E402
-import os  # noqa E402
-import stat  # noqa E402
-import time  # noqa E402
-
 
 def container_exec(binary, container_image):
     '''

diff --git a/library/ceph_volume.py b/library/ceph_volume.py
index 8ba6862164d15ccc170a8c7c289302edcc04b5cb..f35d92acfb5979371d5c68d83de51dac98abd77d 100644 (file)
--- a/library/ceph_volume.py
+++ b/library/ceph_volume.py
@@ -1,5 +1,6 @@
 #!/usr/bin/python
 
+from ansible.module_utils.basic import AnsibleModule
 import datetime
 import copy
 import json
@@ -187,9 +188,6 @@ EXAMPLES = '''
 '''
 
 
-from ansible.module_utils.basic import AnsibleModule  # noqa 4502
-
-
 def fatal(message, module):
     '''
     Report a fatal error and exit

diff --git a/library/radosgw_realm.py b/library/radosgw_realm.py
index cc05bfcd0983c5ef40c0e5e439b5726f9f083122..3150d180385eb37d6d9e0c1c0fb9e4c5aba873a9 100644 (file)
--- a/library/radosgw_realm.py
+++ b/library/radosgw_realm.py
@@ -15,6 +15,10 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -81,13 +85,6 @@ EXAMPLES = '''
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa E402
-import datetime  # noqa E402
-import json  # noqa E402
-import os  # noqa E402
-import stat  # noqa E402
-import time  # noqa E402
-
 
 def container_exec(binary, container_image):
     '''

diff --git a/library/radosgw_user.py b/library/radosgw_user.py
index f1757cf5531e8f67b2f38d1da862895ca93c6196..0c54870e1d5f8283c35c2488114eb84a7d6cf053 100644 (file)
--- a/library/radosgw_user.py
+++ b/library/radosgw_user.py
@@ -15,6 +15,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -129,13 +134,6 @@ EXAMPLES = '''
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa E402
-import datetime  # noqa E402
-import json  # noqa E402
-import os  # noqa E402
-import stat  # noqa E402
-import time  # noqa E402
-
 
 def container_exec(binary, container_image):
     '''

diff --git a/library/radosgw_zone.py b/library/radosgw_zone.py
index 92e3e1f1465f715f7948a7124a8ff58245b3db33..0b9f4a80bd09af889ae6912b945ba06d51c0572c 100644 (file)
--- a/library/radosgw_zone.py
+++ b/library/radosgw_zone.py
@@ -15,6 +15,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -114,13 +119,6 @@ EXAMPLES = '''
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa E402
-import datetime  # noqa E402
-import json  # noqa E402
-import os  # noqa E402
-import stat  # noqa E402
-import time  # noqa E402
-
 
 def container_exec(binary, container_image):
     '''

diff --git a/library/radosgw_zonegroup.py b/library/radosgw_zonegroup.py
index e14b03eb24948eefddea8ef1f9beab0337597eb2..8aec4f60099338a19f996ebfa87b7515ab6cf056 100644 (file)
--- a/library/radosgw_zonegroup.py
+++ b/library/radosgw_zonegroup.py
@@ -15,6 +15,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -101,13 +106,6 @@ EXAMPLES = '''
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa E402
-import datetime  # noqa E402
-import json  # noqa E402
-import os  # noqa E402
-import stat  # noqa E402
-import time  # noqa E402
-
 
 def container_exec(binary, container_image):
     '''