]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
mgr/orch: use keyword rather than positional arg
authorMichael Fritch <mfritch@suse.com>
Thu, 4 Jun 2020 16:39:51 +0000 (10:39 -0600)
committerMichael Fritch <mfritch@suse.com>
Fri, 5 Jun 2020 00:46:38 +0000 (18:46 -0600)
use keyword `service_id` from the orch cli

Signed-off-by: Michael Fritch <mfritch@suse.com>
src/pybind/mgr/orchestrator/module.py

index 0518941c6e0f964ed8d1e9236cc075619aafee3a..7947cdb408c4ea019fb7280cf6421362c7e06eba 100644 (file)
@@ -818,7 +818,8 @@ Usage:
             raise OrchestratorValidationError('unrecognized command -i; -h or --help for usage')
 
         spec = ServiceSpec(
-            'mds', fs_name,
+            service_type='mds',
+            service_id=fs_name,
             placement=PlacementSpec.from_string(placement),
         )
 
@@ -878,7 +879,7 @@ Usage:
             raise OrchestratorValidationError('unrecognized command -i; -h or --help for usage')
 
         spec = NFSServiceSpec(
-            svc_id,
+            service_id=svc_id,
             pool=pool,
             namespace=namespace,
             placement=PlacementSpec.from_string(placement),
@@ -1023,7 +1024,8 @@ Usage:
             raise OrchestratorValidationError('unrecognized command -i; -h or --help for usage')
 
         spec = ServiceSpec(
-            'mds', fs_name,
+            service_type='mds',
+            service_id=fs_name,
             placement=PlacementSpec.from_string(placement),
             unmanaged=unmanaged)
 
@@ -1088,7 +1090,7 @@ Usage:
             raise OrchestratorValidationError('unrecognized command -i; -h or --help for usage')
 
         spec = NFSServiceSpec(
-            svc_id,
+            service_id=svc_id,
             pool=pool,
             namespace=namespace,
             placement=PlacementSpec.from_string(placement),