mgr/dashboard: Misleading warning when no eligible devices are available for OSD...

Fixes: https://tracker.ceph.com/issues/75050
Signed-off-by: Naman Munet <naman.munet@ibm.com>

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-form/osd-form.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-form/osd-form.component.html
index e863ac021d31cb5ca7f60aebc0d075420b344b39..d232aba2339499f872d489cd41d7d0963f69a74e 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-form/osd-form.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-form/osd-form.component.html
@@ -10,12 +10,15 @@
           #formDir="ngForm"
           [formGroup]="form"
           novalidate>
-      <cd-alert-panel *ngIf="!deploymentOptions?.recommended_option"
+      <cd-alert-panel *ngIf="availDevices?.length === 0"
                       type="warning"
                       class="mx-3"
                       i18n>
-        No devices(HDD, SSD or NVME) were found. Creation of OSDs will remain
-        disabled until devices are added.
+        <div cdsStack="vertical"
+             [gap]="2">
+          <span class="cds--type-heading-compact-01">No eligible devices found for OSD creation.</span>
+          <span class="cds--type-body-compact-01">Physical disks may be present, but none meet the requirements (unused, unformatted, and not already configured by Ceph).</span>
+        </div>
       </cd-alert-panel>
       <div class="accordion">
         <div class="accordion-item">

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-form/osd-form.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-form/osd-form.component.spec.ts
index 162a429f690d4a34b4715a27129b314e5250c6d4..d3676c20c0154774a969d7974422df200d4ecf07 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-form/osd-form.component.spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-form/osd-form.component.spec.ts
@@ -230,11 +230,6 @@ describe('OsdFormComponent', () => {
       expect(label.innerHTML).not.toContain('Recommended');
     });
 
-    it('should display form', () => {
-      fixtureHelper.expectElementVisible('cd-alert-panel', false);
-      fixtureHelper.expectElementVisible('.card-body form', true);
-    });
-
     describe('without data devices selected', () => {
       it('should disable preview button', () => {
         component.simpleDeployment = false;