]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
crimson/common/tri_mutex: minor cleanup to be consistent
authorYingxin Cheng <yingxin.cheng@intel.com>
Mon, 3 Jun 2024 06:31:35 +0000 (14:31 +0800)
committerMatan Breizman <mbreizma@redhat.com>
Thu, 6 Jun 2024 13:57:02 +0000 (13:57 +0000)
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
src/crimson/common/tri_mutex.cc

index 698b9b43e174ba8a2cd37a408afa88e506a111e5..9576f8df6bca7168114b2e9898098718dc44818c 100644 (file)
@@ -85,9 +85,8 @@ bool tri_mutex::try_lock_for_read() noexcept
   if (!writers && !exclusively_used && waiters.empty()) {
     ++readers;
     return true;
-  } else {
-    return false;
   }
+  return false;
 }
 
 void tri_mutex::unlock_for_read()
@@ -135,11 +134,9 @@ bool tri_mutex::try_lock_for_write() noexcept
 {
   LOG_PREFIX(tri_mutex::try_lock_for_write());
   DEBUGDPP("", *this);
-  if (!readers && !exclusively_used) {
-    if (waiters.empty()) {
-      ++writers;
-      return true;
-    }
+  if (!readers && !exclusively_used && waiters.empty()) {
+    ++writers;
+    return true;
   }
   return false;
 }