]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
rgw:Wrong x-rgw-quota-bucket-objects header when bucket quota is disabled
authorRaja Sharma <raja@ibm.com>
Sun, 17 Nov 2024 08:58:24 +0000 (14:28 +0530)
committerRaja Sharma <raja@ibm.com>
Fri, 22 Nov 2024 09:03:51 +0000 (14:33 +0530)
This commit introduces to get quota settings if bucket quota is enabled

Fixes: https://tracker.ceph.com/issues/68211
Signed-off-by: Raja Sharma <raja@ibm.com>
src/rgw/rgw_rest_s3.cc

index a245fca9945ce5b5cf2a5a4eca126be0ad3bd5be..68223405cf4193784ffb61af8812d9560421b30d 100644 (file)
@@ -2399,11 +2399,17 @@ static void dump_bucket_metadata(req_state *s, rgw::sal::Bucket* bucket,
   if (s->auth.identity->is_owner_of(bucket->get_owner())) {
     const auto& user_info = s->user->get_info();
     const auto& bucket_quota = s->bucket->get_info().quota; // bucket quota
-    dump_header(s, "X-RGW-Quota-User-Size", static_cast<long long>(user_info.quota.user_quota.max_size));
-    dump_header(s, "X-RGW-Quota-User-Objects", static_cast<long long>(user_info.quota.user_quota.max_objects));
     dump_header(s, "X-RGW-Quota-Max-Buckets", static_cast<long long>(user_info.max_buckets));
-    dump_header(s, "X-RGW-Quota-Bucket-Size", static_cast<long long>(bucket_quota.max_size));
-    dump_header(s, "X-RGW-Quota-Bucket-Objects", static_cast<long long>(bucket_quota.max_objects));
+
+    if (user_info.quota.user_quota.enabled){
+      dump_header(s, "X-RGW-Quota-User-Size", static_cast<long long>(user_info.quota.user_quota.max_size));
+      dump_header(s, "X-RGW-Quota-User-Objects", static_cast<long long>(user_info.quota.user_quota.max_objects));
+    }
+
+    if (bucket_quota.enabled){
+      dump_header(s, "X-RGW-Quota-Bucket-Size", static_cast<long long>(bucket_quota.max_size));
+      dump_header(s, "X-RGW-Quota-Bucket-Objects", static_cast<long long>(bucket_quota.max_objects));
+    }
   }
 }