]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commitdiff
Make test 306 use null and zero device nodes on SCRATCH_MNT
authorJan Kara <jack@suse.cz>
Tue, 14 May 2013 12:02:50 +0000 (07:02 -0500)
committerRich Johnston <rjohnston@sgi.com>
Tue, 14 May 2013 12:02:50 +0000 (07:02 -0500)
In one place of test 306, we mistakenly used /dev/null and /dev/zero
instead of equivalent devices created on tested filesystem. So we were
not really testing the functionality we intended.

Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
--

tests/generic/306

index e8e0fc0a0a9ffada0295dd9138f368d7001c3de8..f45d142774fb29d61a2441b16fbc7018a2bd86e2 100644 (file)
@@ -73,9 +73,9 @@ _scratch_mount -o ro || _fail "Could not mount scratch readonly"
 echo "== try to create new file"
 touch $SCRATCH_MNT/this_should_fail 2>&1 | _filter_scratch
 echo "== pwrite to null device"
-$XFS_IO_PROG -F -c "pwrite 0 512" /dev/null | _filter_xfs_io
+$XFS_IO_PROG -F -c "pwrite 0 512" $DEVNULL | _filter_xfs_io
 echo "== pread from zero device"
-$XFS_IO_PROG -F -c "pread 0 512" /dev/zero | _filter_xfs_io
+$XFS_IO_PROG -F -c "pread 0 512" $DEVZERO | _filter_xfs_io
 
 echo "== truncating write to null device"
 echo foo > $DEVNULL 2>&1 | _filter_scratch