]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commitdiff
net: phy: qcom: qca807x: normalize return value of gpio_get
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 19 Feb 2026 00:56:00 +0000 (16:56 -0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 21 Feb 2026 00:09:07 +0000 (16:09 -0800)
The GPIO get callback is expected to return 0 or 1 (or a negative error
code). Ensure that the value returned by qca807x_gpio_get() is
normalized to the [0, 1] range.

Fixes: 86ef402d805d ("gpiolib: sanitize the return value of gpio_chip::get()")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Link: https://patch.msgid.link/aZZeyr2ysqqk2GqA@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/qcom/qca807x.c

index d8f1ce5a7128d66f14eecf287d0f6f4f3b3b9671..6004da5741af37fa78c8101dc4ce8734826aec94 100644 (file)
@@ -375,7 +375,7 @@ static int qca807x_gpio_get(struct gpio_chip *gc, unsigned int offset)
        reg = QCA807X_MMD7_LED_FORCE_CTRL(offset);
        val = phy_read_mmd(priv->phy, MDIO_MMD_AN, reg);
 
-       return FIELD_GET(QCA807X_GPIO_FORCE_MODE_MASK, val);
+       return !!FIELD_GET(QCA807X_GPIO_FORCE_MODE_MASK, val);
 }
 
 static int qca807x_gpio_set(struct gpio_chip *gc, unsigned int offset, int value)