]> git.apps.os.sepia.ceph.com Git - teuthology.git/commitdiff
packaging: fix syntax for py3 compat
authorKyr Shatskyy <kyrylo.shatskyy@suse.com>
Thu, 21 Nov 2019 14:36:47 +0000 (15:36 +0100)
committerKyr Shatskyy <kyrylo.shatskyy@gmail.com>
Thu, 21 Nov 2019 21:16:10 +0000 (22:16 +0100)
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
teuthology/packaging.py

index 3230463eb43b4344174e662bce415399d1c81e19..50763f02bb585a40fba76a559d2e4438afb2cc2d 100644 (file)
@@ -657,7 +657,7 @@ class GitbuilderProject(object):
 
         :returns: A string URI. Ex: ref/master
         """
-        ref_name, ref_val = self._choose_reference().items()[0]
+        ref_name, ref_val = next(iter(self._choose_reference().items()))
         if ref_name == 'sha1':
             return 'sha1/%s' % ref_val
         else:
@@ -691,7 +691,7 @@ class GitbuilderProject(object):
             names = ('ref', 'tag', 'branch', 'sha1')
             vars = (ref, tag, branch, sha1)
             # filter(None,) filters for truth
-            if len(filter(None, vars)) > 1:
+            if sum(1 for _ in vars if _) > 1:
                 log.warning(
                     "More than one of ref, tag, branch, or sha1 supplied; "
                     "using %s",
@@ -880,7 +880,7 @@ class ShamanProject(GitbuilderProject):
         req_obj['project'] = self.project
         req_obj['flavor'] = flavor
         req_obj['distros'] = '%s/%s' % (self.distro, self.arch)
-        ref_name, ref_val = self._choose_reference().items()[0]
+        ref_name, ref_val = list(self._choose_reference().items())[0]
         if ref_name == 'tag':
             req_obj['sha1'] = self._sha1 = self._tag_to_sha1()
         elif ref_name == 'sha1':