]> git.apps.os.sepia.ceph.com Git - ceph-ansible.git/commitdiff
update: fix ceph-crash stop task
authorGuillaume Abrioux <gabrioux@redhat.com>
Tue, 4 May 2021 09:42:15 +0000 (11:42 +0200)
committerGuillaume Abrioux <gabrioux@redhat.com>
Wed, 5 May 2021 07:47:32 +0000 (09:47 +0200)
This is a workaround for an issue in ansible.
When trying to stop/mask/disable this service in one task, the stop
didn't actually happen, the task doesn't fail but for some reason the
container is still present and running.
Then the task starting the service in the role ceph-crash fails because
it can't start the container since it's already running with the same
name.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1955393
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 3db1ea7ec41475243559beff50b7011773c021e5)

infrastructure-playbooks/rolling_update.yml

index 786561a5807d3eb11a00a16d23ec059cf71b1a84..3bc82b3d6d82da6037cc3f0e15668f86464ae5b7 100644 (file)
       systemd:
         name: "{{ 'ceph-crash@' + ansible_facts['hostname'] if containerized_deployment | bool else 'ceph-crash.service' }}"
         state: stopped
+        daemon_reload: yes
+
+    # it needs to be done in a separate task otherwise the stop just before doesn't work.
+    - name: mask and disable the ceph-crash service
+      systemd:
+        name: "{{ 'ceph-crash@' + ansible_facts['hostname'] if containerized_deployment | bool else 'ceph-crash.service' }}"
         enabled: no
         masked: yes