]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-deploy.git/commitdiff
add a note about for tmp files
authorAlfredo Deza <alfredo.deza@inktank.com>
Tue, 26 Nov 2013 15:55:48 +0000 (09:55 -0600)
committerAlfredo Deza <alfredo.deza@inktank.com>
Tue, 26 Nov 2013 15:55:48 +0000 (09:55 -0600)
Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
ceph_deploy/hosts/remotes.py

index 5317f34cc4b11514649cb2579464a2e7984aa857..2f5e54484a1b4b928798c432bd339e828974b3d6 100644 (file)
@@ -69,6 +69,9 @@ def write_conf(cluster, conf, overwrite):
 
 def write_keyring(path, key):
     """ create a keyring file """
+    # Note that we *require* to avoid deletion of the temp file
+    # otherwise we risk not being able to copy the contents from
+    # one file system to the other, hence the `delete=False`
     tmp_file = tempfile.NamedTemporaryFile(delete=False)
     tmp_file.write(key)
     tmp_file.close()