]> git-server-git.apps.pok.os.sepia.ceph.com Git - jerasure.git/commitdiff
Resolve cppcheck Signed integer overflow error
authorBrad Hubbard <bhubbard@redhat.com>
Mon, 10 Apr 2017 07:47:45 +0000 (17:47 +1000)
committerBrad Hubbard <bhubbard@redhat.com>
Mon, 10 Apr 2017 07:47:45 +0000 (17:47 +1000)
The type of expression '1<<31' is signed int and this causes cppcheck to
issue the following warning.

src/gf_w32.c:681]: (error) Signed integer overflow for expression
'1<<31'.

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
src/reed_sol.c

index 82edacb3c2ce2cf63e01a37cadb576a06a14d921..72cbff893439fcb6c7b033dc78795434f8eb294e 100644 (file)
@@ -136,7 +136,7 @@ static gf_t GF32;
 void reed_sol_galois_w32_region_multby_2(char *region, int nbytes)
 {
   if (prim32 == -1) {
-    prim32 = galois_single_multiply((1 << 31), 2, 32);
+    prim32 = galois_single_multiply(((gf_val_32_t)1 << 31), 2, 32);
     if (!gf_init_hard(&GF32, 32, GF_MULT_BYTWO_b, GF_REGION_DEFAULT, GF_DIVIDE_DEFAULT,
                       prim32, 0, 0, NULL, NULL)) {
       fprintf(stderr, "Error: Can't initialize the GF for reed_sol_galois_w32_region_multby_2\n");