]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
mgr/dashboard: Datatable catches select events from other datatables
authorVolker Theile <vtheile@suse.com>
Wed, 12 Aug 2020 14:25:05 +0000 (16:25 +0200)
committerVolker Theile <vtheile@suse.com>
Wed, 12 Aug 2020 14:25:05 +0000 (16:25 +0200)
Ensure we do not process DOM 'select' events, see https://github.com/swimlane/ngx-datatable/issues/899.

Fixes: https://tracker.ceph.com/issues/46903
Signed-off-by: Volker Theile <vtheile@suse.com>
src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.ts

index 51259b27b16f24d6f86244e37e3f0bb6ee61123f..3744770a539358b0cf6176c14ca4fe34185951b5 100644 (file)
@@ -696,8 +696,12 @@ export class TableComponent implements AfterContentChecked, OnInit, OnChanges, O
   }
 
   onSelect($event: any) {
-    this.selection.selected = $event['selected'];
-    this.updateSelection.emit(_.clone(this.selection));
+    // Ensure we do not process DOM 'select' events.
+    // https://github.com/swimlane/ngx-datatable/issues/899
+    if (_.has($event, 'selected')) {
+      this.selection.selected = $event['selected'];
+      this.updateSelection.emit(_.clone(this.selection));
+    }
   }
 
   toggleColumn(column: CdTableColumn) {