cmake,run-make-check.sh,deb,rpm: disable SPDK by default

but we still enable it in `run-make-check.sh`

* cmake: disable SPDK by default
* run-make-check.sh: enable WITH_SPDK so at least we can ensure it
  builds
* deb,rpm: add uuid-dev / libuuid-devel as a "make check" dependency

Fixes: https://tracker.ceph.com/issues/41330
Signed-off-by: Kefu Chai <kchai@redhat.com>

diff --git a/CMakeLists.txt b/CMakeLists.txt
index fc15544bc1871fa44ab27bec54bc02a9cd686086..92acfd2f2a6d8e07f93e19564b0003ab274b4f54 100644 (file)
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -283,7 +283,7 @@ if(WITH_BLUESTORE_PMEM)
   set(HAVE_BLUESTORE_PMEM ON)
 endif()
 
-CMAKE_DEPENDENT_OPTION(WITH_SPDK "Enable SPDK" ON
+CMAKE_DEPENDENT_OPTION(WITH_SPDK "Enable SPDK" OFF
   "CMAKE_SYSTEM_PROCESSOR MATCHES i386|i686|amd64|x86_64|AMD64|aarch64" OFF)
 if(WITH_SPDK)
   if(NOT WITH_BLUESTORE)

diff --git a/ceph.spec.in b/ceph.spec.in
index baf5ba02016b21a9e6b8efd827a3b5b7db7adb6e..251e9ddd5237603c7fd2ac8433569e21041f17da 100644 (file)
--- a/ceph.spec.in
+++ b/ceph.spec.in
@@ -173,7 +173,6 @@ BuildRequires:      libnl3-devel
 BuildRequires: liboath-devel
 BuildRequires: libtool
 BuildRequires: libxml2-devel
-BuildRequires: libuuid-devel
 BuildRequires: make
 BuildRequires: ncurses-devel
 BuildRequires: parted
@@ -198,6 +197,7 @@ BuildRequires:  librabbitmq-devel
 %endif
 %if 0%{with make_check}
 BuildRequires:  jq
+BuildRequires: libuuid-devel
 BuildRequires: python%{_python_buildid}-bcrypt
 BuildRequires: python%{_python_buildid}-coverage
 BuildRequires: python%{_python_buildid}-nose

diff --git a/debian/control b/debian/control
index a9a35b2cd72d1a44dba315484123aa6e63d61a51..374564fe3f3dba7611df2963525afcf270784c21 100644 (file)
--- a/debian/control
+++ b/debian/control
@@ -83,7 +83,7 @@ Build-Depends: cmake (>= 3.5),
 # Crimson      ragel,
 # Make-Check   socat,
 # Crimson      systemtap-sdt-dev,
-               uuid-dev,
+# Make-Check   uuid-dev,
                uuid-runtime,
                valgrind,
                virtualenv | python-virtualenv,

diff --git a/run-make-check.sh b/run-make-check.sh
index cc5ff9fefb23fb7173da8d9c8676512ef9a725cd..32d88e28332c1e10ce535c9d496ee528f8e50abe 100755 (executable)
--- a/run-make-check.sh
+++ b/run-make-check.sh
@@ -111,7 +111,7 @@ function run() {
     BUILD_MAKEOPTS=${BUILD_MAKEOPTS:-$DEFAULT_MAKEOPTS}
     test "$BUILD_MAKEOPTS" && echo "make will run with option(s) $BUILD_MAKEOPTS"
     CHECK_MAKEOPTS=${CHECK_MAKEOPTS:-$DEFAULT_MAKEOPTS}
-    CMAKE_BUILD_OPTS="-DWITH_GTEST_PARALLEL=ON -DWITH_FIO=ON -DWITH_SEASTAR=ON -DWITH_CEPHFS_SHELL=ON"
+    CMAKE_BUILD_OPTS="-DWITH_GTEST_PARALLEL=ON -DWITH_FIO=ON -DWITH_SEASTAR=ON -DWITH_CEPHFS_SHELL=ON -DWITH_SPDK=ON"
     CMAKE_BUILD_OPTS+=$(detect_ceph_dev_pkgs)
     cat <<EOM
 Note that the binaries produced by this script do not contain correct time