]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commitdiff
Fix old comment about HyperClockCache and SecondaryCache (#11517)
authorPeter Dillinger <peterd@fb.com>
Wed, 7 Jun 2023 20:21:31 +0000 (13:21 -0700)
committerPeter Dillinger <peterd@fb.com>
Fri, 9 Jun 2023 15:11:20 +0000 (08:11 -0700)
Summary:
Support was added in 8.1.0

Pull Request resolved: https://github.com/facebook/rocksdb/pull/11517

Test Plan: comments only

Reviewed By: anand1976

Differential Revision: D46489929

Pulled By: pdillinger

fbshipit-source-id: 4fd30078389065c9ec225bf55b6773f1641f0646

include/rocksdb/cache.h

index b64ad701417190dbed0b68a3cfbecd7b4781a102..532e6e4afd87880e8d0ba529bfde9a0675f9615e 100644 (file)
@@ -374,7 +374,6 @@ inline std::shared_ptr<SecondaryCache> NewCompressedSecondaryCache(
 // * Requires an extra tuning parameter: see estimated_entry_charge below.
 // Similarly, substantially changing the capacity with SetCapacity could
 // harm efficiency.
-// * SecondaryCache is not yet supported.
 // * Cache priorities are less aggressively enforced, which could cause
 // cache dilution from long range scans (unless they use fill_cache=false).
 // * Can be worse for small caches, because if almost all of a cache shard is