ceph-dev-pipeline: Fix NotSerializableException when iterating readProperties result

Jenkins periodically saves its state to disk so it can resume builds
after a restart or when waiting for an agent. Some Java objects cannot
be saved this way. We were looping over a properties file in a way that
created one of those unsaveable objects, which caused Jenkins to crash
when it happened to try saving at that moment.

The fix changes the loop to only work with plain strings, which Jenkins
has no trouble saving.

Signed-off-by: David Galloway <david.galloway@ibm.com>

diff --git a/ceph-dev-pipeline/build/Jenkinsfile b/ceph-dev-pipeline/build/Jenkinsfile
index 5d603a5777c0006a3172d6005c54569722839848..5265f37d4e2758fd96e3aff88d298f9a9b712cbf 100644 (file)
--- a/ceph-dev-pipeline/build/Jenkinsfile
+++ b/ceph-dev-pipeline/build/Jenkinsfile
@@ -282,8 +282,8 @@ pipeline {
                   // as written during ceph-source-dist but we don't to be able to define
                   // ceph-releases.git or chacra.ceph.com as parameters for ceph-dev-pipeline.
                   def props = readProperties file: "${WORKSPACE}/dist/other_envvars"
-                  for (p in props) {
-                    env."${p.key}" = p.value
+                  for (def key in props.keySet()) {
+                    env."${key}" = props[key]
                   }
                 }
                 def branch_ui_value = env.BRANCH